spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mridul Muralidharan <mri...@gmail.com>
Subject Re: [discuss] Removing individual commit messages from the squash commit message
Date Sat, 18 Jul 2015 22:45:53 GMT
Just to clarify, the proposal is to have a single commit msg giving the
jira and pr id?
That sounds like a good change to have.

Regards
Mridul

On Saturday, July 18, 2015, Reynold Xin <rxin@databricks.com> wrote:

> I took a look at the commit messages in git log -- it looks like the
> individual commit messages are not that useful to include, but do make the
> commit messages more verbose. They are usually just a bunch of extremely
> concise descriptions of "bug fixes", "merges", etc:
>
>     cb3f12d [xxx] add whitespace
>     6d874a6 [xxx] support pyspark for yarn-client
>
>     89b01f5 [yyy] Update the unit test to add more cases
>     275d252 [yyy] Address the comments
>     7cc146d [yyy] Address the comments
>     2624723 [yyy] Fix rebase conflict
>     45befaa [yyy] Update the unit test
>     bbc1c9c [yyy] Fix checkpointing doesn't retain driver port issue
>
>
> Anybody against removing those from the merge script so the log looks
> cleaner? If nobody feels strongly about this, we can just create a JIRA to
> remove them, and only keep the author names.
>
>

Mime
View raw message