spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reynold Xin <r...@databricks.com>
Subject Fwd: pull requests no longer closing by commit messages with "closes #xxxx"
Date Tue, 09 Jun 2015 00:59:40 GMT
FYI.

---------- Forwarded message ----------
From: John Greet (GitHub Staff) <support@github.com>
Date: Mon, Jun 8, 2015 at 5:50 PM
Subject: Re: pull requests no longer closing by commit messages with
"closes #xxxx"
To: Reynold Xin <rxin@databricks.com>


Hi Reynold,

The problem here is that the commits closing those pull requests were
fetched by our mirroring process, which doesn't have permission to close
issues, instead of pushed by a user in the apache GitHub organization.

Usually the repository receives regular, I assume automated, pushes to its
master branch, but there was a gap in those pushes between 2pm PDT on June
5th and 1:16 PM PDT June 7th. This happened at least once before back in
November. Now that those pushes have resumed pull requests are closing
normally once again.

Let us know if you have any other questions.

Cheers,
John



> I'm a committer on Apache Spark (the most active open source project in
the data space). We use GitHub as the primary way to accept contributions.
We use a custom merge script to merge pull requests rather than GitHub's
merge button in order to preserve a linear commit history. Part of the
merge script relies on the "closes #xxxx" feature to close the
corresponding pull requests.
>
> I noticed recently that pull requests are no longer automatically closed,
even if the commits are merged with the message "closes #xxxx". Here are
two recent examples:
>
> https://github.com/apache/spark/pull/6670
> https://github.com/apache/spark/pull/6689
>
> Can you take a look at what's going on? Thanks.

Mime
View raw message