spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcelo Vanzin <van...@cloudera.com>
Subject Re: [NOTICE] [BUILD] Minor changes to Spark's build
Date Thu, 13 Nov 2014 18:53:27 GMT
Hey Patrick,

On Thu, Nov 13, 2014 at 10:49 AM, Patrick Wendell <pwendell@gmail.com> wrote:
> I'm not sure chaining activation works like that. At least in my
> experience activation based on properties only works for properties
> explicitly specified at the command line rather than declared
> elsewhere in the pom.

That's true, but note the code I posted activates a profile based on
the lack of a property being set, which is why it works. Granted, I
did not test that if you activate the other profile, the one with the
property check will be disabled.

> I any case, I think Prashant just didn't document that his patch
> required -Pscala-2.10 explicitly, which is what he said further up in
> the thread. And Sandy has a solution that has better behavior than
> that, which is nice.

Yeah, I saw Sandy's patch now and it's probably a better solution
(since it doesn't abuse the sort of tricky maven profile stuff as
much).

-- 
Marcelo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org


Mime
View raw message