Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@spark.apache.org
From: pwendell <git@git.apache.org>
To: dev@spark.apache.org
Reply-To: dev@spark.apache.org
References: <git-pr-42-spark@git.apache.org>
In-Reply-To: <git-pr-42-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through
 refacto...
Content-Type: text/plain
Message-Id: <20140314055014.4AAE4980D7A@tyr.zones.apache.org>
Date: Fri, 14 Mar 2014 05:50:14 +0000 (UTC)

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10597094
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
    @@ -68,19 +105,53 @@ private[spark] class SparkUI(sc: SparkContext) extends Logging {
     
       /** Initialize all components of the server */
       def start() {
    -    // NOTE: This is decoupled from bind() because of the following dependency cycle:
    -    //  DAGScheduler() requires that the port of this server is known
    -    //  This server must register all handlers, including JobProgressUI, before binding
    -    //  JobProgressUI registers a listener with SparkContext, which requires sc to initialize
    +    storage.start()
         jobs.start()
    +    env.start()
         exec.start()
    +
    +    // Listen for events from the SparkContext if it exists, otherwise from persisted storage
    +    val eventBus = if (live) {
    +      val loggingEnabled = conf.getBoolean("spark.eventLog.enabled", false)
    --- End diff --
    
    I'm referring to lines 115-120.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---