Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@spark.apache.org
From: sryza <git@git.apache.org>
To: dev@spark.apache.org
Reply-To: dev@spark.apache.org
References: <git-pr-86-spark@git.apache.org>
In-Reply-To: <git-pr-86-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-1126. spark-app preliminary
Content-Type: text/plain
Message-Id: <20140307204309.7988693A7DD@tyr.zones.apache.org>
Date: Fri,  7 Mar 2014 20:43:09 +0000 (UTC)

Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/86#discussion_r10399046
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy
    +
    +import java.io.File
    +import java.net.URL
    +import java.net.URLClassLoader
    +
    +import scala.collection.mutable.ArrayBuffer
    +
    +object SparkSubmit {
    +  val YARN = 1
    +  val STANDALONE = 2
    +  val MESOS = 4
    +  val LOCAL = 8
    +  val ALL_CLUSTER_MGRS = YARN | STANDALONE | MESOS | LOCAL
    +
    +  var clusterManager: Int = LOCAL
    +
    +  def main(args: Array[String]) {
    +    val appArgs = new SparkSubmitArguments(args)
    +
    +    if (appArgs.master != null) {
    +      if (appArgs.master.startsWith("yarn")) {
    +        clusterManager = YARN
    +      } else if (appArgs.master.startsWith("spark")) {
    +        clusterManager = STANDALONE
    +      } else if (appArgs.master.startsWith("mesos")) {
    +        clusterManager = MESOS
    +      } else if (appArgs.master.startsWith("local")) {
    +        clusterManager = LOCAL
    +      } else {
    +        System.err.println("master must start with yarn, mesos, spark, or local")
    +        System.exit(1)
    +      }
    +    }
    +
    +    val deployOnCluster = appArgs.deployMode == "cluster"
    --- End diff --
    
    On the other hand, it might make more sense to move towards consistency between yarn and standalone/mesos, for which MASTER only specifies the cluster manager, and not the application's deploy mode.  For this, we would allow just giving --master to spark-submit as "yarn", and yarn-client vs. yarn-standalone would be inferred depending on --deploy-mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---