Return-Path: 
 <dev-return-5090-apmail-spark-dev-archive=spark.apache.org@spark.apache.org>
X-Original-To: apmail-spark-dev-archive@minotaur.apache.org
Delivered-To: apmail-spark-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B98701025F
	for <apmail-spark-dev-archive@minotaur.apache.org>;
 Thu,  6 Mar 2014 05:30:59 +0000 (UTC)
Received: (qmail 72171 invoked by uid 500); 6 Mar 2014 05:30:58 -0000
Delivered-To: apmail-spark-dev-archive@spark.apache.org
Received: (qmail 72116 invoked by uid 500); 6 Mar 2014 05:30:57 -0000
Mailing-List: contact dev-help@spark.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@spark.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@spark.apache.org>
List-Post: <mailto:dev@spark.apache.org>
List-Id: <dev.spark.apache.org>
Reply-To: dev@spark.apache.org
Delivered-To: mailing list dev@spark.apache.org
Received: (qmail 72105 invoked by uid 99); 6 Mar 2014 05:30:56 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 05:30:56 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 6B413938685; Thu,  6 Mar 2014 05:30:56 +0000 (UTC)
From: pwendell <git@git.apache.org>
To: dev@spark.apache.org
Reply-To: dev@spark.apache.org
References: <git-pr-90-spark@git.apache.org>
In-Reply-To: <git-pr-90-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-782. Shade ASM
Content-Type: text/plain
Message-Id: <20140306053056.6B413938685@tyr.zones.apache.org>
Date: Thu,  6 Mar 2014 05:30:56 +0000 (UTC)

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/90#discussion_r10332109
  
    --- Diff: graphx/pom.xml ---
    @@ -70,6 +70,10 @@
           <artifactId>scalacheck_${scala.binary.version}</artifactId>
           <scope>test</scope>
         </dependency>
    +    <dependency>
    --- End diff --
    
    Hey @rxin @ankurdave - would you guys be okay if we moved `BytecodeUtils.scala` to Spark core and made it `private[spark]`? It has an asm dependency which is causing conflict issues and it's a bit nicer if we can just deal with this only in Spark core and not separately from the GraphX package. Plus those utilities might be useful outside of graphx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---