spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Debasish Das <debasish.da...@gmail.com>
Subject Re: Development methodology
Date Mon, 03 Mar 2014 00:41:42 GMT
Hi Reynold,

I checked and atlassian stash also has pull request feature...

In the spark README it says: "Contributions via GitHub pull requests are
gladly accepted from their original author."

What happens if a spark pull requests comes from stash ? will you guys
accept it or all pull requests has to come through github ?

I could merge for example @dbtsai github lbfgs branch to my branch at
stash...

Thanks.
Deb



On Sat, Mar 1, 2014 at 12:43 PM, Debasish Das <debasish.das83@gmail.com>wrote:

> Stash is an enterprise git from atlassian..
>
> I got it...Basically the PRs are managed by github and if I have to work
> on a PR, I should rather make use of my github account...
>
> Thanks for the clarification.
>
>
>
> On Sat, Mar 1, 2014 at 12:27 PM, Reynold Xin <rxin@databricks.com> wrote:
>
>> I'm not sure what you mean by enterprise stash.
>>
>> But PR is a concept unique to Github. There is no PR model in normal git
>> or
>> the git ASF maintains.
>>
>>
>> On Sat, Mar 1, 2014 at 11:28 AM, Debasish Das <debasish.das83@gmail.com
>> >wrote:
>>
>> > Hi,
>> >
>> > We have a mirror repo of spark at our internal stash.
>> >
>> > We are adding changes to a fork of the mirror so that down the line we
>> can
>> > push the contributions back to Spark git.
>> >
>> > I am not sure what's the exact the development methodology we should
>> follow
>> > as things are a bit complicated due to enterprise stash.
>> >
>> > Any suggestions would be great.
>> >
>> > I have follow usecases:
>> >
>> > 1. Ask for a pull request and push the changes from stash mirror
>> upstream
>> > to the spark apache git.
>> >
>> > 2. I am working on 2 PR that are currently open. What's the best way to
>> > work on those ?
>> > Can I get those PR through the stash mirror of Spark git or those PRs
>> are
>> > only available on github ?
>> >
>> > Thanks.
>> > Deb
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message