spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1255: Allow user to pass Serializer obje...
Date Sun, 16 Mar 2014 03:18:58 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/149#discussion_r10637809
  
    --- Diff: core/src/main/scala/org/apache/spark/Dependency.scala ---
    @@ -43,12 +44,13 @@ abstract class NarrowDependency[T](rdd: RDD[T]) extends Dependency(rdd)
{
      * Represents a dependency on the output of a shuffle stage.
      * @param rdd the parent RDD
      * @param partitioner partitioner used to partition the shuffle output
    - * @param serializerClass class name of the serializer to use
    + * @param serializer [[Serializer]] to use. If set to null, the default serializer, as
specified
    + *                  by `spark.serializer` config option, will be used.
      */
     class ShuffleDependency[K, V](
         @transient rdd: RDD[_ <: Product2[K, V]],
         val partitioner: Partitioner,
    -    val serializerClass: String = null)
    +    val serializer: Serializer = null)
    --- End diff --
    
    @rxin seems fine to me... thanks for digging into it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message