spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Fri, 14 Mar 2014 06:49:34 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10597778
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -196,13 +152,46 @@ class DAGScheduler(
         }))
       }
     
    -  def addSparkListener(listener: SparkListener) {
    -    listenerBus.addListener(listener)
    +  // Called by TaskScheduler to report task's starting.
    +  def taskStarted(task: Task[_], taskInfo: TaskInfo) {
    +    eventProcessActor ! BeginEvent(task, taskInfo)
    +  }
    +
    +  // Called to report that a task has completed and results are being fetched remotely.
    +  def taskGettingResult(task: Task[_], taskInfo: TaskInfo) {
    +    eventProcessActor ! GettingResultEvent(task, taskInfo)
    +  }
    +
    +  // Called by TaskScheduler to report task completions or failures.
    +  def taskEnded(
    +      task: Task[_],
    +      reason: TaskEndReason,
    +      result: Any,
    +      accumUpdates: Map[Long, Any],
    +      taskInfo: TaskInfo,
    +      taskMetrics: TaskMetrics) {
    +    eventProcessActor ! CompletionEvent(task, reason, result, accumUpdates, taskInfo,
taskMetrics)
    +  }
    +
    +  // Called by TaskScheduler when an executor fails.
    +  def executorLost(execId: String) {
    +    eventProcessActor ! ExecutorLost(execId)
    +  }
    +
    +  // Called by TaskScheduler when a host is added
    +  def executorGained(execId: String, host: String) {
    --- End diff --
    
    I'd go with `executorAdded` here and everywhere else we have this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message