spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Thu, 13 Mar 2014 20:26:55 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10584092
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkReplayerBus.scala ---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.scheduler
    +
    +import java.io.InputStream
    +
    +import scala.io.Source
    +
    +import it.unimi.dsi.fastutil.io.FastBufferedInputStream
    +import org.apache.hadoop.fs.{Path, FileSystem}
    +import org.json4s.jackson.JsonMethods._
    +
    +import org.apache.spark.{Logging, SparkConf}
    +import org.apache.spark.io.CompressionCodec
    +import org.apache.spark.util.{JsonProtocol, Utils}
    +
    +/**
    + * An EventBus that replays logged events from persisted storage
    + */
    +private[spark] class SparkReplayerBus(conf: SparkConf) extends EventBus with Logging
{
    --- End diff --
    
    I think "something you can attach listeners to" pretty much means pub-sub (the difference
is how often you publish; in replay mode we publish once in the beginning). I propose the
following:
    
    trait SparkListenerBus
    ReplayListenerBus extends SparkListenerBus
    LiveListenerBus / PollingListenerBus / AsynchronousListenerBus extends SparkListenerBus


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message