spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1103] [WIP] Automatic garbage collectio...
Date Thu, 13 Mar 2014 17:44:35 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/126#discussion_r10576368
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
    @@ -273,8 +310,9 @@ private[spark] class MapOutputTrackerMaster(conf: SparkConf)
         // This might be called on the MapOutputTrackerMaster if we're running in local mode.
       }
     
    -  def has(shuffleId: Int): Boolean = {
    -    cachedSerializedStatuses.get(shuffleId).isDefined || mapStatuses.contains(shuffleId)
    +  protected def cleanup(cleanupTime: Long) {
    +    mapStatuses.clearOldValues(cleanupTime)
    +    cachedSerializedStatuses.clearOldValues(cleanupTime)
       }
     }
     
    --- End diff --
    
    Not related to your patch, but looks like we over-indented in ```convertMapStatuses```
in L346, and GitHub won't let me comment down there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message