spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1096, a space after comment start style ...
Date Thu, 13 Mar 2014 04:46:12 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/124#discussion_r10552654
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMessages.scala ---
    @@ -35,9 +35,9 @@ private[storage] object BlockManagerMessages {
       case class RemoveRdd(rddId: Int) extends ToBlockManagerSlave
     
     
    -  //////////////////////////////////////////////////////////////////////////////////
    +  // ////////////////////////////////////////////////////////////////////////////////
       // Messages from slaves to the master.
    -  //////////////////////////////////////////////////////////////////////////////////
    +  // ////////////////////////////////////////////////////////////////////////////////
       sealed trait ToBlockManagerMaster
    --- End diff --
    
    It seems like it's better for us to either fix the style checker, or replace the // with
something else. using a hint to turn the checker off for this comment block is pretty weird.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message