spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1103] [WIP] Automatic garbage collectio...
Date Thu, 13 Mar 2014 04:45:27 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/126#discussion_r10552645
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1025,6 +1025,14 @@ abstract class RDD[T: ClassTag](
         checkpointData.flatMap(_.getCheckpointFile)
       }
     
    +  def cleanup() {
    --- End diff --
    
    Why not just make it private[spark] for now? Otherwise we'll have to preserve the semantics
and visibility of this function for a long time. If we change around the way we do garbage
collection. But if we make it private now we can wait for feedback from people who want to
use this (I'm still not sure exactly what case that would be) in deciding how and what to
expose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message