spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1128: set hadoop task properties when co...
Date Thu, 13 Mar 2014 04:21:58 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/101#discussion_r10552358
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkHadoopWriter.scala ---
    @@ -15,18 +15,19 @@
      * limitations under the License.
      */
     
    -package org.apache.hadoop.mapred
    --- End diff --
    
    I successfully compiled against 0.23.7, 2.2.0, and 1.0.4, so I think we're good to go
on this change (especially since it's intended to be an internal helper). Would you mind changing
the private[apache]s to private[spark]s and update the class comment? That'd be sweet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message