spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <>
Subject [GitHub] spark pull request: [SPARK-1103] [WIP] Automatic garbage collectio...
Date Thu, 13 Mar 2014 02:41:33 GMT
Github user pwendell commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/TimeStampedWeakValueHashMap.scala
    @@ -0,0 +1,112 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.util
    +import scala.collection.{JavaConversions, immutable}
    +import java.util
    +import java.lang.ref.WeakReference
    +import java.util.concurrent.ConcurrentHashMap
    +import org.apache.spark.Logging
    +private[util] case class TimeStampedWeakValue[T](timestamp: Long, weakValue: WeakReference[T])
    +  def this(timestamp: Long, value: T) = this(timestamp, new WeakReference[T](value))
    + * A map that stores the timestamp of when a key was inserted along with the value,
    + * while ensuring that the values are weakly referenced. If the value is garbage collected
    + * the weak reference is null, get() operation returns the key be non-existent. However,
    + * the key is actually not removed in the current implementation. Key-value pairs whose
    --- End diff --
    Right now this will allow the key set to grow infinitely right? Would a very simple solution
work... e.g. every 1000 puts you scan the entire map and delete the null-valued keys?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message