spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1230: [WIP] Enable SparkContext.addJars(...
Date Wed, 12 Mar 2014 05:49:45 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/119#discussion_r10506355
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -130,6 +130,16 @@ class SparkContext(
     
       val isLocal = (master == "local" || master.startsWith("local["))
     
    +  // Create a classLoader for use by the driver so that jars added via addJar are available
to the
    +  // driver.  Do this before all other initialization so that any thread pools created
for this
    +  // SparkContext uses the class loader.
    +  // Note that this is config-enabled as classloaders can introduce subtle side effects
    +  private[spark] val classLoader = if (conf.getBoolean("spark.driver.loadAddedJars",
false)) {
    +    val loader = new SparkURLClassLoader(Array.empty[URL], this.getClass.getClassLoader)
    +    Thread.currentThread.setContextClassLoader(loader)
    --- End diff --
    
    Will this only work if addJars is called from the thread that created the SparkContext?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message