spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: Upgrade Jetty to 9.1.3.v20140225.
Date Mon, 10 Mar 2014 07:14:04 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/113#discussion_r10420573
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -120,26 +120,25 @@ private[spark] object JettyUtils extends Logging {
     
       private def addFilters(handlers: Seq[ServletContextHandler], conf: SparkConf) {
         val filters: Array[String] = conf.get("spark.ui.filters", "").split(',').map(_.trim())
    -    filters.foreach {
    -      case filter : String => 
    -        if (!filter.isEmpty) {
    -          logInfo("Adding filter: " + filter)
    -          val holder : FilterHolder = new FilterHolder()
    -          holder.setClassName(filter)
    -          // get any parameters for each filter
    -          val paramName = "spark." + filter + ".params"
    -          val params = conf.get(paramName, "").split(',').map(_.trim()).toSet
    -          params.foreach {
    -            case param : String =>
    -              if (!param.isEmpty) {
    -                val parts = param.split("=")
    -                if (parts.length == 2) holder.setInitParameter(parts(0), parts(1))
    -             }
    -          }
    -          val enumDispatcher = java.util.EnumSet.of(DispatcherType.ASYNC, DispatcherType.ERROR,

    -            DispatcherType.FORWARD, DispatcherType.INCLUDE, DispatcherType.REQUEST)
    -          handlers.foreach { case(handler) => handler.addFilter(holder, "/*", enumDispatcher)
}
    +    filters.foreach { filter =>
    --- End diff --
    
    Here it's only a coding style change for the block. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message