spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1205: Clean up callSite/origin/generator...
Date Mon, 10 Mar 2014 01:32:12 GMT
Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/106#discussion_r10417318
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1031,8 +1026,10 @@ abstract class RDD[T: ClassTag](
     
       private var storageLevel: StorageLevel = StorageLevel.NONE
     
    -  /** Record user function generating this RDD. */
    -  @transient private[spark] val origin = sc.getCallSite()
    +  /** Info about the function call site where this was created (e.g. `textFile`, `parallelize`).
*/
    +  @transient private[spark] val callSite = Utils.getCallSiteInfo
    +
    +  private[spark] def getCallSiteString = Utils.formatCallSiteInfo(callSite)
    --- End diff --
    
    Why name this `getCallSiteString instead of `getCallSite`? If we're only going to return
a string to users it's fine to use the second one. If we wanted to return a more complex thing
we could make `CallSiteInfo` a public class, but then we could also call that `getCallSiteInfo`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message