spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1194] Fix the same-RDD rule for cache r...
Date Fri, 07 Mar 2014 16:24:38 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/96#discussion_r10388411
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
    @@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager, maxMemory:
Long)
             while (maxMemory - (currentMemory - selectedMemory) < space && iterator.hasNext)
{
               val pair = iterator.next()
               val blockId = pair.getKey
    -          if (rddToAdd.isDefined && rddToAdd == getRddId(blockId)) {
    -            logInfo("Will not store " + blockIdToAdd + " as it would require dropping
another " +
    -              "block from the same RDD")
    --- End diff --
    
    Agree, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message