spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Fri, 07 Mar 2014 00:22:05 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10368558
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -19,33 +19,43 @@ package org.apache.spark.scheduler
     
     import java.util.Properties
     
    +import scala.collection.Map
    +
    +import org.apache.spark.util.{Utils, Distribution}
     import org.apache.spark.{Logging, TaskEndReason}
     import org.apache.spark.executor.TaskMetrics
    -import org.apache.spark.util.{Distribution, Utils}
    +import org.apache.spark.storage.StorageStatus
    +
    +sealed trait SparkListenerEvent
    +
    +case class SparkListenerStageSubmitted(stageInfo: StageInfo, properties: Properties =
null)
    +  extends SparkListenerEvent
    +
    +case class SparkListenerStageCompleted(stageInfo: StageInfo) extends SparkListenerEvent
     
    -sealed trait SparkListenerEvents
    +case class SparkListenerTaskStart(stageId: Int, taskInfo: TaskInfo) extends SparkListenerEvent
     
    -case class SparkListenerStageSubmitted(stage: StageInfo, properties: Properties)
    -     extends SparkListenerEvents
    +case class SparkListenerTaskGettingResult(taskInfo: TaskInfo) extends SparkListenerEvent
     
    -case class SparkListenerStageCompleted(stage: StageInfo) extends SparkListenerEvents
    +case class SparkListenerTaskEnd(stageId: Int, taskType: String, reason: TaskEndReason,
    +  taskInfo: TaskInfo, taskMetrics: TaskMetrics) extends SparkListenerEvent
     
    -case class SparkListenerTaskStart(task: Task[_], taskInfo: TaskInfo) extends SparkListenerEvents
    +case class SparkListenerJobStart(jobId: Int, stageIds: Seq[Int], properties: Properties
= null)
    +  extends SparkListenerEvent
     
    -case class SparkListenerTaskGettingResult(
    -  task: Task[_], taskInfo: TaskInfo) extends SparkListenerEvents
    +case class SparkListenerJobEnd(jobId: Int, jobResult: JobResult) extends SparkListenerEvent
     
    -case class SparkListenerTaskEnd(task: Task[_], reason: TaskEndReason, taskInfo: TaskInfo,
    -     taskMetrics: TaskMetrics) extends SparkListenerEvents
    +case class SparkListenerEnvironmentUpdate(environmentDetails: Map[String, Seq[(String,
String)]])
    +  extends SparkListenerEvent
     
    -case class SparkListenerJobStart(job: ActiveJob, stageIds: Array[Int],
    -    properties: Properties = null) extends SparkListenerEvents
    +case class SparkListenerExecutorsStateChange(storageStatusList: Seq[StorageStatus])
    --- End diff --
    
    Sounds reasonable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message