spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: Fix #SPARK-1149 Bad partitioners can cause Spa...
Date Thu, 06 Mar 2014 23:13:06 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/44#discussion_r10366461
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -847,6 +847,8 @@ class SparkContext(
           partitions: Seq[Int],
           allowLocal: Boolean,
           resultHandler: (Int, U) => Unit) {
    +    val outIndex = partitions.toSet.diff(rdd.partitions.map(_.index).toSet)
    --- End diff --
    
    could this check be even simpler? E.g. why can't it just do something like:
    ```
    partitions.foreach{ p => 
      require(p >= 0 && p < rdd.partitions.size, s"Invalid partition requested:
$p")
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message