spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Thu, 06 Mar 2014 21:55:07 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10362915
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -978,6 +971,11 @@ class DAGScheduler(
           logDebug("Additional executor lost message for " + execId +
                    "(epoch " + currentEpoch + ")")
         }
    +    // Block manager master actor should not be null except during tests
    +    if (blockManagerMaster.driverActor != null) {
    +      val storageStatusList = blockManagerMaster.getStorageStatus
    +      listenerBus.post(SparkListenerExecutorsStateChange(storageStatusList))
    --- End diff --
    
    @pwendell is the plan still to avoid having shared data structures between the UI and
the main spark code?  This seems to be contradictory to that plan but not sure if that's something
you're planning to fix later/separately?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message