spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Thu, 06 Mar 2014 20:54:24 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10360102
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
    @@ -69,19 +100,55 @@ private[spark] class SparkUI(sc: SparkContext) extends Logging {
         //  DAGScheduler() requires that the port of this server is known
    --- End diff --
    
    This isn't really related to your change but as long as you're changing things here, I
don't think this comment is relevant anymore...or at least I don't think DAGScheduler requires
that the port of this server is known?  So maybe just delete that line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message