spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Thu, 06 Mar 2014 19:58:03 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10357808
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -194,10 +148,46 @@ class DAGScheduler(
               }
           }
         }))
    +
    +    // Start listening for block manager registration
    +    blockManagerMaster.registrationListener.foreach(_.setListenerBus(listenerBus))
    --- End diff --
    
    Now that the listenerBus lives in Spark Context, can you move this line there?  It seems
a little unrelated to the DAGScheduler


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message