spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-782. Shade ASM
Date Thu, 06 Mar 2014 05:30:56 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/90#discussion_r10332109
  
    --- Diff: graphx/pom.xml ---
    @@ -70,6 +70,10 @@
           <artifactId>scalacheck_${scala.binary.version}</artifactId>
           <scope>test</scope>
         </dependency>
    +    <dependency>
    --- End diff --
    
    Hey @rxin @ankurdave - would you guys be okay if we moved `BytecodeUtils.scala` to Spark
core and made it `private[spark]`? It has an asm dependency which is causing conflict issues
and it's a bit nicer if we can just deal with this only in Spark core and not separately from
the GraphX package. Plus those utilities might be useful outside of graphx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message