spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-782. Shade ASM
Date Thu, 06 Mar 2014 05:26:54 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/90#discussion_r10332066
  
    --- Diff: core/pom.xml ---
    @@ -269,6 +269,37 @@
                         </environmentVariables>
                     </configuration>
                 </plugin>
    +            <plugin>
    +              <groupId>org.apache.maven.plugins</groupId>
    +              <artifactId>maven-shade-plugin</artifactId>
    +              <version>2.0</version>
    +              <executions>
    +                <execution>
    +                  <phase>package</phase>
    +                  <goals>
    +                    <goal>shade</goal>
    +                  </goals>
    +                  <configuration>
    +                    <relocations>
    +                      <relocation>
    +                        <pattern>org.objectweb.asm</pattern>
    +                        <shadedPattern>shaded.org.objectweb.asm</shadedPattern>
    --- End diff --
    
    It might be nice to do `org.apache.spark.shaded` that way if someone else ends up with
a stack trace it will be more clear what is going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message