spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1126. spark-app preliminary
Date Thu, 06 Mar 2014 04:29:36 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/86#discussion_r10331320
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
    @@ -0,0 +1,178 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy
    +
    +import java.io.BufferedReader
    +import java.io.InputStream
    +import java.io.InputStreamReader
    +import java.io.PrintStream
    +
    +import scala.collection.mutable.HashMap
    +import scala.collection.mutable.Map
    +import scala.collection.mutable.ArrayBuffer
    +import scala.collection.JavaConverters._
    +
    +object SparkApp {
    +  val CLIENT = 1
    +  val CLUSTER = 2
    +  val YARN = 1
    --- End diff --
    
    It's not possible for something to be both, but there are some options that we want to
apply the same way for multiple different cluster managers.
    
    E.g. on both standalone and Mesos mode, --executor-cores should translate to setting the
spark.executor.memory Java system property, and with the flags, we can express that with
    +      new Opt(appArgs.executorMemory, STANDALONE | MESOS, CLIENT, null, null, "spark.executor.memory"),
    
    I couldn't find a way to do this with Enumerations.  Do you know if there is one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message