spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request: fix #SPARK-1149 Bad partitioners can cause Spa...
Date Tue, 04 Mar 2014 05:12:53 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/44#discussion_r10243179
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -847,6 +847,7 @@ class SparkContext(
           partitions: Seq[Int],
           allowLocal: Boolean,
           resultHandler: (Int, U) => Unit) {
    +    require(partitions.toSet.diff(rdd.partitions.map(_.index).toSet).isEmpty, "partition
index out of range")
    --- End diff --
    
    suppose the original rdd contains 10 partitions, 0 - 9, partitionFilterFunc is n % 2 =
0, 
    
    then filter(s => partitionFilterFunc(s.index)) returns a list (split1, split3, split5,
split7, split9), zipWithIndex will return  ((split1, 0), (split3, 1), (split5, 2), (split7,
3), (split9, 4))
    
    .map { case(split, idx) => new PartitionPruningRDDPartition(idx, split) : Partition
} takes 0, 1, 2, 3, 4 as idx....so the index space is still continuous......
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message