spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...
Date Mon, 03 Mar 2014 20:31:43 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/43#discussion_r10227330
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala ---
    @@ -146,6 +146,12 @@ object BlockFetcherIterator {
         }
     
         protected def splitLocalRemoteBlocks(): ArrayBuffer[FetchRequest] = {
    +      // Make remote requests at most maxBytesInFlight / 5 in length; the reason to keep
them
    +      // smaller than maxBytesInFlight is to allow multiple, parallel fetches from up
to 5
    +      // nodes, rather than blocking on reading output from one node.
    +      val maxRequestSize = math.max(maxBytesInFlight / 5, 1L)
    --- End diff --
    
    Should we call this "targetRequestSize" or something?  I think min is more correct than
max -- because it always waits until requests are at least this big before truncating them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message