spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...
Date Mon, 03 Mar 2014 16:27:04 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/33#discussion_r10216556
  
    --- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
    @@ -18,25 +18,27 @@
     package org.apache.spark.network
     
     import org.apache.spark._
    +import org.apache.spark.SparkSaslServer
     
     import scala.collection.mutable.{HashMap, Queue, ArrayBuffer}
     
    -import java.io._
     import java.nio._
     import java.nio.channels._
    -import java.nio.channels.spi._
     import java.net._
     
     
     private[spark]
     abstract class Connection(val channel: SocketChannel, val selector: Selector,
    -    val socketRemoteConnectionManagerId: ConnectionManagerId)
    +    val socketRemoteConnectionManagerId: ConnectionManagerId, val connectionId: ConnectionId)
       extends Logging {
     
    -  def this(channel_ : SocketChannel, selector_ : Selector) = {
    +  var sparkSaslServer : SparkSaslServer = null
    --- End diff --
    
    I'll fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message