spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...
Date Sat, 01 Mar 2014 18:53:00 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11#discussion_r10191970
  
    --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala ---
    @@ -208,4 +209,25 @@ class FileSuite extends FunSuite with LocalSparkContext {
         assert(rdd.count() === 3)
         assert(rdd.count() === 3)
       }
    +
    +  test ("prevent user from overwriting the empty directory") {
    --- End diff --
    
    These tests are looking good, but they don't cover the newAPI code path you added. Would
you mind adding tests for that too? You could either create two new tests or just have these
tests each use both the old and the new API's.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message