spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Super minor: Add require for mergeCo...
Date Thu, 20 Feb 2014 23:45:53 GMT
GitHub user aarondav opened a pull request:

    https://github.com/apache/incubator-spark/pull/623

    Super minor: Add require for mergeCombiners in combineByKey

    We changed the behavior in 0.9.0 from requiring that mergeCombiners be null when mapSideCombine
was false to requiring that mergeCombiners *never* be null, for external sorting. This patch
adds a require() to make this behavior change explicitly messaged rather than resulting in
a NPE.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aarondav/incubator-spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-spark/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #623
    
----
commit 520b80c7bef100e7b1c2b0fb6388569ac0335681
Author: Aaron Davidson <aaron@databricks.com>
Date:   2014-02-20T23:41:20Z

    Super minor: Add require for mergeCombiners in combineByKey
    
    We changed the behavior in 0.9.0 from requiring that mergeCombiners
    be null when mapSideCombine was false to requiring that mergeCombiners
    *never* be null, for external sorting. This patch adds a require()
    to make this behavior change explicitly messaged rather than resulting in
    a NPE.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message