spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...
Date Fri, 28 Feb 2014 22:00:17 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10183222
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala ---
    @@ -339,8 +217,8 @@ class JobLogger(val user: String, val logDirName: String)
        * @param jobEnd Job end event
        */
       override def onJobEnd(jobEnd: SparkListenerJobEnd) {
    -    val job = jobEnd.job
    -    var info = "JOB_ID=" + job.jobId
    +    val jobID = jobEnd.jobId
    --- End diff --
    
    Yeah I realized after that comment that there seems to be inconsistency in
    the way ID is named so feel free to leave it however you prefer.
    
    
    On Fri, Feb 28, 2014 at 1:55 PM, andrewor14 <notifications@github.com>wrote:
    
    > In core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala:
    >
    > > @@ -339,8 +217,8 @@ class JobLogger(val user: String, val logDirName: String)
    > >     * @param jobEnd Job end event
    > >     */
    > >    override def onJobEnd(jobEnd: SparkListenerJobEnd) {
    > > -    val job = jobEnd.job
    > > -    var info = "JOB_ID=" + job.jobId
    > > +    val jobID = jobEnd.jobId
    >
    > Yeah, actually I had jobId before, but to make it consistent with the rest
    > of the file I reverted it back to jobID. I'll change it back.
    >
    > --
    > Reply to this email directly or view it on GitHub<https://github.com/apache/spark/pull/42/files#r10183037>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message