spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Patch for SPARK-942
Date Tue, 25 Feb 2014 01:26:29 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/180#discussion_r10020702
  
    --- Diff: core/src/main/scala/org/apache/spark/serializer/JavaSerializer.scala ---
    @@ -25,7 +25,22 @@ import org.apache.spark.SparkConf
     
     private[spark] class JavaSerializationStream(out: OutputStream) extends SerializationStream
{
       val objOut = new ObjectOutputStream(out)
    -  def writeObject[T](t: T): SerializationStream = { objOut.writeObject(t); this }
    +  var counter = 0;
    +  /* Calling reset to avoid memory leak:
    +   * http://stackoverflow.com/questions/1281549/memory-leak-traps-in-the-java-standard-api
    +   * But only call it every 1000th time to avoid bloated serialization streams (when
    +   * the stream 'resets' object class descriptions have to be re-written)  
    +   */
    +  def writeObject[T](t: T): SerializationStream = {
    +    objOut.writeObject(t);
    +    if (counter >= 1000) {
    --- End diff --
    
    It's funny we had the same problem earlier in Spark and I looked for a long time and was
convinced this reset() thing didn't work this way. We ended up solving it another way. But
after reading the OOS source code (again) it looks like this is what we want. Good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message