spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...
Date Sun, 23 Feb 2014 01:31:16 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/570#discussion_r9973958
  
    --- Diff: bagel/pom.xml ---
    @@ -51,6 +51,11 @@
           <artifactId>scalacheck_${scala.binary.version}</artifactId>
           <scope>test</scope>
         </dependency>
    +    <dependency>
    +      <groupId>org.slf4j</groupId>
    +      <artifactId>slf4j-log4j12</artifactId>
    +      <scope>test</scope>
    --- End diff --
    
    I did some auditing of this - I think what we want is that in `core/pom.xml` there should
be a dependency on `slf4j-log4j12` that is at the default scope (compile) similar to the sbt
build. Then all of the sub projects will pick it up automatically and it won't need to exist
anywhere in the sub projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message