spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...
Date Mon, 17 Feb 2014 18:57:12 GMT
Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/572#discussion_r9801137
  
    (1 to folds) is preferred, your style is fine though we use 2 space wrapped indents instead
of 4. Would this be possible, though?
    ```
    (1 to folds).map { fold => (
      new PartitionwiseSampledRDD(rdd, 
        new BernoulliSampler[T]((fold - 1) / foldsF, fold / foldsF, complement = false), seed),
       ...
    )}.toList
    ```
    
    anyway up to you but that way avoids breaking a line in a nested expression. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message