From commits-return-34115-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Oct 17 16:53:49 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D884118061A for ; Wed, 17 Oct 2018 16:53:48 +0200 (CEST) Received: (qmail 83862 invoked by uid 500); 17 Oct 2018 14:53:48 -0000 Mailing-List: contact commits-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@spark.apache.org Received: (qmail 83853 invoked by uid 99); 17 Oct 2018 14:53:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2018 14:53:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D5469DFD6B; Wed, 17 Oct 2018 14:53:47 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: srowen@apache.org To: commits@spark.apache.org Message-Id: <0fc982893dcf4d20b700480ae8275472@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: spark git commit: [SPARK-25741][WEBUI] Long URLs are not rendered properly in web UI Date: Wed, 17 Oct 2018 14:53:47 +0000 (UTC) Repository: spark Updated Branches: refs/heads/branch-2.4 b698bd46f -> ac9a6f08a [SPARK-25741][WEBUI] Long URLs are not rendered properly in web UI ## What changes were proposed in this pull request? When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly. ![beforefix](https://user-images.githubusercontent.com/1097932/47009242-9323ba00-d16e-11e8-8262-0848d814442a.jpeg) Both job and stage page are using the class `name-link` for the description URL, so change the style of `a.name-link` to fix it. ## How was this patch tested? Manual test on my local: ![afterfix](https://user-images.githubusercontent.com/1097932/47009269-a46cc680-d16e-11e8-9ff5-0318a20db634.jpeg) Closes #22744 from gengliangwang/fixUILink. Authored-by: Gengliang Wang Signed-off-by: Sean Owen (cherry picked from commit 1901f06211661c19d70f231db235cca3cdb1f2dd) Signed-off-by: Sean Owen Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ac9a6f08 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ac9a6f08 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ac9a6f08 Branch: refs/heads/branch-2.4 Commit: ac9a6f08a19e1896cb6aa123b567cc5c2ffe9067 Parents: b698bd4 Author: Gengliang Wang Authored: Wed Oct 17 09:51:41 2018 -0500 Committer: Sean Owen Committed: Wed Oct 17 09:53:07 2018 -0500 ---------------------------------------------------------------------- core/src/main/resources/org/apache/spark/ui/static/webui.css | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/ac9a6f08/core/src/main/resources/org/apache/spark/ui/static/webui.css ---------------------------------------------------------------------- diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css b/core/src/main/resources/org/apache/spark/ui/static/webui.css index 4b060b0..266eeec 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/webui.css +++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css @@ -88,6 +88,10 @@ a.kill-link { float: right; } +a.name-link { + word-wrap: break-word; +} + span.expand-details { font-size: 10pt; cursor: pointer; --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org For additional commands, e-mail: commits-help@spark.apache.org