spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [MINOR][SS] Fix kafka-0-10-sql trivials
Date Fri, 07 Sep 2018 17:36:18 GMT
Repository: spark
Updated Branches:
  refs/heads/master 22a46ca19 -> 458f5011b


[MINOR][SS] Fix kafka-0-10-sql trivials

## What changes were proposed in this pull request?

Fix unused imports & outdated comments on `kafka-0-10-sql` module. (Found while I was
working on [SPARK-23539](https://github.com/apache/spark/pull/22282))

## How was this patch tested?

Existing unit tests.

Closes #22342 from dongjinleekr/feature/fix-kafka-sql-trivials.

Authored-by: Lee Dongjin <dongjin@apache.org>
Signed-off-by: Sean Owen <sean.owen@databricks.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/458f5011
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/458f5011
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/458f5011

Branch: refs/heads/master
Commit: 458f5011bd52851632c3592ac35f1573bc904d50
Parents: 22a46ca
Author: Lee Dongjin <dongjin@apache.org>
Authored: Fri Sep 7 10:36:15 2018 -0700
Committer: Sean Owen <sean.owen@databricks.com>
Committed: Fri Sep 7 10:36:15 2018 -0700

----------------------------------------------------------------------
 .../apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala   | 1 -
 .../main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala | 1 -
 .../apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala   | 4 ++--
 3 files changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/458f5011/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
----------------------------------------------------------------------
diff --git a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
index 6631ae8..fb209c7 100644
--- a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
+++ b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
@@ -29,7 +29,6 @@ import org.apache.spark.sql.sources.v2.DataSourceOptions
 private[kafka010] class KafkaOffsetRangeCalculator(val minPartitions: Option[Int]) {
   require(minPartitions.isEmpty || minPartitions.get > 0)
 
-  import KafkaOffsetRangeCalculator._
   /**
    * Calculate the offset ranges that we are going to process this batch. If `minPartitions`
    * is not set or is set less than or equal the number of `topicPartitions` that we're going
to

http://git-wip-us.apache.org/repos/asf/spark/blob/458f5011/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
----------------------------------------------------------------------
diff --git a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
index 9d856c9..e6f9d12 100644
--- a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
+++ b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
@@ -17,7 +17,6 @@
 
 package org.apache.spark.sql.kafka010
 
-import java.{util => ju}
 import java.util.UUID
 
 import org.apache.kafka.common.TopicPartition

http://git-wip-us.apache.org/repos/asf/spark/blob/458f5011/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
----------------------------------------------------------------------
diff --git a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
index dc19312..927c56d 100644
--- a/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
+++ b/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
@@ -54,8 +54,8 @@ class KafkaStreamingWriteSupport(
 }
 
 /**
- * A [[DataWriterFactory]] for Kafka writing. Will be serialized and sent to executors to
generate
- * the per-task data writers.
+ * A [[StreamingDataWriterFactory]] for Kafka writing. Will be serialized and sent to executors
to
+ * generate the per-task data writers.
  * @param topic The topic that should be written to. If None, topic will be inferred from
  *              a `topic` field in the incoming data.
  * @param producerParams Parameters for Kafka producers in each task.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message