spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lix...@apache.org
Subject spark git commit: [MINOR] Improve documentation for HiveStringType's
Date Fri, 27 Jul 2018 22:34:10 GMT
Repository: spark
Updated Branches:
  refs/heads/master 10f1f1965 -> 34ebcc6b5


[MINOR] Improve documentation for HiveStringType's

The diff should be self-explanatory.

Author: Reynold Xin <rxin@databricks.com>

Closes #21897 from rxin/hivestringtypedoc.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/34ebcc6b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/34ebcc6b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/34ebcc6b

Branch: refs/heads/master
Commit: 34ebcc6b5246c1a47e6d3b2dbb23e368de25219e
Parents: 10f1f19
Author: Reynold Xin <rxin@databricks.com>
Authored: Fri Jul 27 15:34:06 2018 -0700
Committer: Xiao Li <gatorsmile@gmail.com>
Committed: Fri Jul 27 15:34:06 2018 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/sql/types/HiveStringType.scala    | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/34ebcc6b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveStringType.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveStringType.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveStringType.scala
index e0bca93..4eb3226 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveStringType.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveStringType.scala
@@ -56,14 +56,18 @@ object HiveStringType {
 }
 
 /**
- * Hive char type.
+ * Hive char type. Similar to other HiveStringType's, these datatypes should only used for
+ * parsing, and should NOT be used anywhere else. Any instance of these data types should
be
+ * replaced by a [[StringType]] before analysis.
  */
 case class CharType(length: Int) extends HiveStringType {
   override def simpleString: String = s"char($length)"
 }
 
 /**
- * Hive varchar type.
+ * Hive varchar type. Similar to other HiveStringType's, these datatypes should only used
for
+ * parsing, and should NOT be used anywhere else. Any instance of these data types should
be
+ * replaced by a [[StringType]] before analysis.
  */
 case class VarcharType(length: Int) extends HiveStringType {
   override def simpleString: String = s"varchar($length)"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message