spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gurwls...@apache.org
Subject spark git commit: [SPARK-24526][BUILD][TEST-MAVEN] Spaces in the build dir causes failures in the build/mvn script
Date Mon, 18 Jun 2018 16:34:29 GMT
Repository: spark
Updated Branches:
  refs/heads/master e219e692e -> bce177552


[SPARK-24526][BUILD][TEST-MAVEN] Spaces in the build dir causes failures in the build/mvn
script

## What changes were proposed in this pull request?

Fix the call to ${MVN_BIN} to be wrapped in quotes so it will handle having spaces in the
path.

## How was this patch tested?

Ran the following to confirm using the build/mvn tool with a space in the build dir now works
without error

```
mkdir /tmp/test\ spaces
cd /tmp/test\ spaces
git clone https://github.com/apache/spark.git
cd spark
# Remove all mvn references in PATH so the script will download mvn to the local dir
./build/mvn -DskipTests clean package
```

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: trystanleftwich <trystan@atscale.com>

Closes #21534 from trystanleftwich/SPARK-24526.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/bce17755
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/bce17755
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/bce17755

Branch: refs/heads/master
Commit: bce177552564a4862bc979d39790cf553a477d74
Parents: e219e69
Author: trystanleftwich <trystan@atscale.com>
Authored: Tue Jun 19 00:34:24 2018 +0800
Committer: hyukjinkwon <gurwls223@apache.org>
Committed: Tue Jun 19 00:34:24 2018 +0800

----------------------------------------------------------------------
 build/mvn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/bce17755/build/mvn
----------------------------------------------------------------------
diff --git a/build/mvn b/build/mvn
index efa4f93..1405983 100755
--- a/build/mvn
+++ b/build/mvn
@@ -154,4 +154,4 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
 echo "Using \`mvn\` from path: $MVN_BIN" 1>&2
 
 # Last, call the `mvn` command as usual
-${MVN_BIN} -DzincPort=${ZINC_PORT} "$@"
+"${MVN_BIN}" -DzincPort=${ZINC_PORT} "$@"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message