spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wenc...@apache.org
Subject spark git commit: [SPARK-23826][TEST] TestHiveSparkSession should set default session
Date Wed, 04 Apr 2018 06:31:08 GMT
Repository: spark
Updated Branches:
  refs/heads/master 5cfd5fabc -> 16ef6baa3


[SPARK-23826][TEST] TestHiveSparkSession should set default session

## What changes were proposed in this pull request?
In TestHive, the base spark session does this in getOrCreate(), we emulate that behavior for
tests.

## How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #20969 from gatorsmile/setDefault.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/16ef6baa
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/16ef6baa
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/16ef6baa

Branch: refs/heads/master
Commit: 16ef6baa36ac11c72cfeafaa2363e6b69f0ba573
Parents: 5cfd5fa
Author: gatorsmile <gatorsmile@gmail.com>
Authored: Wed Apr 4 14:31:03 2018 +0800
Committer: Wenchen Fan <wenchen@databricks.com>
Committed: Wed Apr 4 14:31:03 2018 +0800

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/16ef6baa/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
index a7006a1..965aea2 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
@@ -159,10 +159,6 @@ private[hive] class TestHiveSparkSession(
     private val loadTestTables: Boolean)
   extends SparkSession(sc) with Logging { self =>
 
-  // TODO(SPARK-23826): TestHiveSparkSession should set default session the same way as
-  // TestSparkSession, but doing this the same way breaks many tests in the package. We need
-  // to investigate and find a different strategy.
-
   def this(sc: SparkContext, loadTestTables: Boolean) {
     this(
       sc,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message