spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject spark git commit: [SQL] Mark strategies with override for clarity.
Date Fri, 20 Oct 2017 06:57:46 GMT
Repository: spark
Updated Branches:
  refs/heads/master b034f2565 -> b84f61cd7

[SQL] Mark strategies with override for clarity.

## What changes were proposed in this pull request?

This is a very trivial PR, simply marking `strategies` in `SparkPlanner` with the `override`
keyword for clarity since it is overriding `strategies` in `QueryPlanner` two levels up in
the class hierarchy. I was reading through the code to learn a bit and got stuck on this fact
for a little while, so I figured this may be helpful so that another developer new to the
project doesn't get stuck where I was.

I did not make a JIRA ticket for this because it is so trivial, but I'm happy to do so to
adhere to the contribution guidelines if required.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review before opening a pull request.

Author: Eric Perry <>

Closes #19537 from ericjperry/override-strategies.


Branch: refs/heads/master
Commit: b84f61cd79a365edd4cc893a1de416c628d9906b
Parents: b034f25
Author: Eric Perry <>
Authored: Thu Oct 19 23:57:41 2017 -0700
Committer: gatorsmile <>
Committed: Thu Oct 19 23:57:41 2017 -0700

 .../main/scala/org/apache/spark/sql/execution/SparkPlanner.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala
index b143d44..7404887 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala
@@ -33,7 +33,7 @@ class SparkPlanner(
   def numPartitions: Int = conf.numShufflePartitions
-  def strategies: Seq[Strategy] =
+  override def strategies: Seq[Strategy] =
     experimentalMethods.extraStrategies ++
       extraPlanningStrategies ++ (
       DataSourceV2Strategy ::

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message