spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wenc...@apache.org
Subject spark git commit: [SPARK-19810][BUILD][FOLLOW-UP] jcl-over-slf4j dependency needs to be compile scope for SBT build
Date Fri, 21 Jul 2017 14:42:42 GMT
Repository: spark
Updated Branches:
  refs/heads/master 2f1468429 -> 113399b8b


[SPARK-19810][BUILD][FOLLOW-UP] jcl-over-slf4j dependency needs to be compile scope for SBT
build

## What changes were proposed in this pull request?

jcl-over-slf4j dependency needs to be compile scope for SBT build, to make it available for
commons-logging dependents like Hadoop

https://github.com/apache/spark/pull/17150#issuecomment-316950717
https://github.com/apache/spark/pull/17150/files#r128728089

## How was this patch tested?

Manual tests

Author: Sean Owen <sowen@cloudera.com>

Closes #18703 from srowen/SPARK-19810.2.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/113399b8
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/113399b8
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/113399b8

Branch: refs/heads/master
Commit: 113399b8b0efd8f5e64fc929aec9d2d1a6fc68f2
Parents: 2f14684
Author: Sean Owen <sowen@cloudera.com>
Authored: Fri Jul 21 22:42:37 2017 +0800
Committer: Wenchen Fan <wenchen@databricks.com>
Committed: Fri Jul 21 22:42:37 2017 +0800

----------------------------------------------------------------------
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/113399b8/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 1b81263..c243343 100644
--- a/pom.xml
+++ b/pom.xml
@@ -510,7 +510,7 @@
         <groupId>org.slf4j</groupId>
         <artifactId>jcl-over-slf4j</artifactId>
         <version>${slf4j.version}</version>
-        <scope>runtime</scope>
+        <!-- runtime scope is appropriate, but causes SBT build problems -->
       </dependency>
       <dependency>
         <groupId>log4j</groupId>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message