spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown
Date Mon, 03 Apr 2017 09:09:25 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-2.1 ca144106b -> 77700ea38


[MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown

# What changes were proposed in this pull request?

It seems there are several non-breaking spaces were inserted into several `.md`s and they
look breaking rendering markdown files.

These are different. For example, this can be checked via `python` as below:

```python
>>> " "
'\xc2\xa0'
>>> " "
' '
```

_Note that it seems this PR description automatically replaces non-breaking spaces into normal
spaces. Please open a `vi` and copy and paste it into `python` to verify this (do not copy
the characters here)._

I checked the output below in  Sapari and Chrome on Mac OS and, Internal Explorer on Windows
10.

**Before**

![2017-04-03 12 37 17](https://cloud.githubusercontent.com/assets/6477701/24594655/50aaba02-186a-11e7-80bb-d34b17a3398a.png)
![2017-04-03 12 36 57](https://cloud.githubusercontent.com/assets/6477701/24594654/50a855e6-186a-11e7-94e2-661e56544b0f.png)

**After**

![2017-04-03 12 36 46](https://cloud.githubusercontent.com/assets/6477701/24594657/53c2545c-186a-11e7-9a73-00529afbfd75.png)
![2017-04-03 12 36 31](https://cloud.githubusercontent.com/assets/6477701/24594658/53c286c0-186a-11e7-99c9-e66b1f510fe7.png)

## How was this patch tested?

Manually checking.

These instances were found via

```
grep --include=*.scala --include=*.python --include=*.java --include=*.r --include=*.R --include=*.md
--include=*.r -r -I " " .
```

in Mac OS.

It seems there are several instances more as below:

```
./docs/sql-programming-guide.md:        │   ├── ...
./docs/sql-programming-guide.md:        │   │
./docs/sql-programming-guide.md:        │   ├── country=US
./docs/sql-programming-guide.md:        │   │   └── data.parquet
./docs/sql-programming-guide.md:        │   ├── country=CN
./docs/sql-programming-guide.md:        │   │   └── data.parquet
./docs/sql-programming-guide.md:        │   └── ...
./docs/sql-programming-guide.md:            ├── ...
./docs/sql-programming-guide.md:            │
./docs/sql-programming-guide.md:            ├── country=US
./docs/sql-programming-guide.md:            │   └── data.parquet
./docs/sql-programming-guide.md:            ├── country=CN
./docs/sql-programming-guide.md:            │   └── data.parquet
./docs/sql-programming-guide.md:            └── ...
./sql/core/src/test/README.md:│   ├── *.avdl                  # Testing Avro IDL(s)
./sql/core/src/test/README.md:│   └── *.avpr                  # !! NO TOUCH !! Protocol
files generated from Avro IDL(s)
./sql/core/src/test/README.md:│   ├── gen-avro.sh             # Script used to generate
Java code for Avro
./sql/core/src/test/README.md:│   └── gen-thrift.sh           # Script used to generate
Java code for Thrift
```

These seems generated via `tree` command which inserts non-breaking spaces. They do not look
causing any problem for rendering within code blocks and I did not fix it to reduce the overhead
to manually replace it when it is overwritten via `tree` command in the future.

Author: hyukjinkwon <gurwls223@gmail.com>

Closes #17517 from HyukjinKwon/non-breaking-space.

(cherry picked from commit 364b0db75308ddd346b4ab1e032680e8eb4c1753)
Signed-off-by: Sean Owen <sowen@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/77700ea3
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/77700ea3
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/77700ea3

Branch: refs/heads/branch-2.1
Commit: 77700ea38540b8326c37623abeebabf3d2497418
Parents: ca14410
Author: hyukjinkwon <gurwls223@gmail.com>
Authored: Mon Apr 3 10:09:11 2017 +0100
Committer: Sean Owen <sowen@cloudera.com>
Committed: Mon Apr 3 10:09:21 2017 +0100

----------------------------------------------------------------------
 README.md              | 2 +-
 docs/building-spark.md | 2 +-
 docs/monitoring.md     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/77700ea3/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index f598323..d861e9f 100644
--- a/README.md
+++ b/README.md
@@ -98,7 +98,7 @@ building for particular Hive and Hive Thriftserver distributions.
 Please refer to the [Configuration Guide](http://spark.apache.org/docs/latest/configuration.html)
 in the online documentation for an overview on how to configure Spark.
 
-## Contributing
+## Contributing
 
 Please review the [Contribution to Spark guide](http://spark.apache.org/contributing.html)
 for information on how to get started contributing to the project.

http://git-wip-us.apache.org/repos/asf/spark/blob/77700ea3/docs/building-spark.md
----------------------------------------------------------------------
diff --git a/docs/building-spark.md b/docs/building-spark.md
index 65c2895..0945095 100644
--- a/docs/building-spark.md
+++ b/docs/building-spark.md
@@ -199,7 +199,7 @@ in interactive mode by running `build/sbt`, and then run all build commands
at t
 prompt. For more recommendations on reducing build time, refer to the
 [Useful Developer Tools page](http://spark.apache.org/developer-tools.html).
 
-## Encrypted Filesystems
+## Encrypted Filesystems
 
 When building on an encrypted filesystem (if your home directory is encrypted, for example),
then the Spark build might fail with a "Filename too long" error. As a workaround, add the
following in the configuration args of the `scala-maven-plugin` in the project `pom.xml`:
 

http://git-wip-us.apache.org/repos/asf/spark/blob/77700ea3/docs/monitoring.md
----------------------------------------------------------------------
diff --git a/docs/monitoring.md b/docs/monitoring.md
index bfea572..5c8539d 100644
--- a/docs/monitoring.md
+++ b/docs/monitoring.md
@@ -257,7 +257,7 @@ In the API, an application is referenced by its application ID, `[app-id]`.
 When running on YARN, each application may have multiple attempts, but there are attempt
IDs
 only for applications in cluster mode, not applications in client mode. Applications in YARN
cluster mode
 can be identified by their `[attempt-id]`. In the API listed below, when running in YARN
cluster mode,
-`[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the
YARN application ID.
+`[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the YARN
application ID.
 
 <table class="table">
   <tr><th>Endpoint</th><th>Meaning</th></tr>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message