spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [SPARK-19622][WEBUI] Fix a http error in a paged table when using a `Go` button to search.
Date Fri, 17 Feb 2017 15:11:10 GMT
Repository: spark
Updated Branches:
  refs/heads/master 9d2d2204c -> 021062af0


[SPARK-19622][WEBUI] Fix a http error in a paged table when using a `Go` button to search.

## What changes were proposed in this pull request?

The search function of paged table is not available because of we don't skip the hash data
of the reqeust path.

![](https://issues.apache.org/jira/secure/attachment/12852996/screenshot-1.png)

## How was this patch tested?

Tested manually with my browser.

Author: Stan Zhai <zhaishidan@haizhi.com>

Closes #16953 from stanzhai/fix-webui-paged-table.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/021062af
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/021062af
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/021062af

Branch: refs/heads/master
Commit: 021062af099d06b4b0095c677b3a81d21f867a9d
Parents: 9d2d220
Author: Stan Zhai <zhaishidan@haizhi.com>
Authored: Fri Feb 17 15:11:06 2017 +0000
Committer: Sean Owen <sowen@cloudera.com>
Committed: Fri Feb 17 15:11:06 2017 +0000

----------------------------------------------------------------------
 core/src/main/scala/org/apache/spark/ui/PagedTable.scala | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/021062af/core/src/main/scala/org/apache/spark/ui/PagedTable.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/PagedTable.scala b/core/src/main/scala/org/apache/spark/ui/PagedTable.scala
index 2a7c16b..79974df 100644
--- a/core/src/main/scala/org/apache/spark/ui/PagedTable.scala
+++ b/core/src/main/scala/org/apache/spark/ui/PagedTable.scala
@@ -175,13 +175,14 @@ private[ui] trait PagedTable[T] {
 
       val hiddenFormFields = {
         if (goButtonFormPath.contains('?')) {
-          val querystring = goButtonFormPath.split("\\?", 2)(1)
+          val queryString = goButtonFormPath.split("\\?", 2)(1)
+          val search = queryString.split("#")(0)
           Splitter
             .on('&')
             .trimResults()
             .omitEmptyStrings()
             .withKeyValueSeparator("=")
-            .split(querystring)
+            .split(search)
             .asScala
             .filterKeys(_ != pageSizeFormField)
             .filterKeys(_ != prevPageSizeFormField)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message