spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [SPARK-18396][HISTORYSERVER] Duration" column makes search result confused, maybe we should make it unsearchable
Date Mon, 14 Nov 2016 11:22:43 GMT
Repository: spark
Updated Branches:
  refs/heads/master ae6cddb78 -> 637a0bb88


[SPARK-18396][HISTORYSERVER] Duration" column makes search result confused, maybe we should
make it unsearchable

## What changes were proposed in this pull request?

When we search data in History Server, it will check if any columns contains the search string.
Duration is represented as long value in table, so if we search simple string like "003",
"111", the duration containing "003", ‘111“ will be showed, which make not much sense
to users.
We cannot simply transfer the long value to meaning format like "1 h", "3.2 min" because they
are also used for sorting. Better way to handle it is ban "Duration" columns from searching.

## How was this patch tested

manually tests.

Before("local-1478225166651" pass the filter because its duration in long value, which is
"257244245" contains search string "244"):
![before](https://cloud.githubusercontent.com/assets/5276001/20203166/f851ffc6-a7ff-11e6-8fe6-91a90ca92b23.jpg)

After:
![after](https://cloud.githubusercontent.com/assets/5276001/20178646/2129fbb0-a78d-11e6-9edb-39f885ce3ed0.jpg)

Author: WangTaoTheTonic <wangtao111@huawei.com>

Closes #15838 from WangTaoTheTonic/duration.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/637a0bb8
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/637a0bb8
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/637a0bb8

Branch: refs/heads/master
Commit: 637a0bb88f74712001f32a53ff66fd0b8cb67e4a
Parents: ae6cddb
Author: WangTaoTheTonic <wangtao111@huawei.com>
Authored: Mon Nov 14 12:22:36 2016 +0100
Committer: Sean Owen <sowen@cloudera.com>
Committed: Mon Nov 14 12:22:36 2016 +0100

----------------------------------------------------------------------
 core/src/main/resources/org/apache/spark/ui/static/historypage.js | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/637a0bb8/core/src/main/resources/org/apache/spark/ui/static/historypage.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/historypage.js b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
index 6c0ec8d..8fd9186 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/historypage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
@@ -139,6 +139,9 @@ $(document).ready(function() {
                         {name: 'eighth'},
                         {name: 'ninth'},
                     ],
+                    "columnDefs": [
+                        {"searchable": false, "targets": [5]}
+                    ],
                     "autoWidth": false,
                     "order": [[ 4, "desc" ]]
         };


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message