spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wenc...@apache.org
Subject spark git commit: [SPARK-18442][SQL] Fix nullability of WrapOption.
Date Thu, 17 Nov 2016 03:21:18 GMT
Repository: spark
Updated Branches:
  refs/heads/master 55589987b -> 170eeb345


[SPARK-18442][SQL] Fix nullability of WrapOption.

## What changes were proposed in this pull request?

The nullability of `WrapOption` should be `false`.

## How was this patch tested?

Existing tests.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #15887 from ueshin/issues/SPARK-18442.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/170eeb34
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/170eeb34
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/170eeb34

Branch: refs/heads/master
Commit: 170eeb345f951de89a39fe565697b3e913011768
Parents: 5558998
Author: Takuya UESHIN <ueshin@happy-camper.st>
Authored: Thu Nov 17 11:21:08 2016 +0800
Committer: Wenchen Fan <wenchen@databricks.com>
Committed: Thu Nov 17 11:21:08 2016 +0800

----------------------------------------------------------------------
 .../apache/spark/sql/catalyst/expressions/objects/objects.scala    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/170eeb34/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
index 50e2ac3..0e3d991 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
@@ -341,7 +341,7 @@ case class WrapOption(child: Expression, optType: DataType)
 
   override def dataType: DataType = ObjectType(classOf[Option[_]])
 
-  override def nullable: Boolean = true
+  override def nullable: Boolean = false
 
   override def inputTypes: Seq[AbstractDataType] = optType :: Nil
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message