spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [SPARK-16796][WEB UI] Mask spark.authenticate.secret on Spark environ…
Date Wed, 02 Nov 2016 18:28:11 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-2.0 09178b6ee -> eb790c5b1


[SPARK-16796][WEB UI] Mask spark.authenticate.secret on Spark environ…

## What changes were proposed in this pull request?

Mask `spark.authenticate.secret` on Spark environment page (Web UI).
This is addition to https://github.com/apache/spark/pull/14409

## How was this patch tested?
`./dev/run-tests`
[info] ScalaTest
[info] Run completed in 1 hour, 8 minutes, 38 seconds.
[info] Total number of tests run: 2166
[info] Suites: completed 65, aborted 0
[info] Tests: succeeded 2166, failed 0, canceled 0, ignored 590, pending 0
[info] All tests passed.

Author: Artur Sukhenko <artur.sukhenko@gmail.com>

Closes #14484 from Devian-ua/SPARK-16796.

(cherry picked from commit 14dba45208d8a5511be2cf8ddf22e688ef141e88)
Signed-off-by: Sean Owen <sowen@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/eb790c5b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/eb790c5b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/eb790c5b

Branch: refs/heads/branch-2.0
Commit: eb790c5b110c1227d0d6c8593254de196f65da35
Parents: 09178b6
Author: Artur Sukhenko <artur.sukhenko@gmail.com>
Authored: Sat Aug 6 04:41:47 2016 +0100
Committer: Sean Owen <sowen@cloudera.com>
Committed: Wed Nov 2 18:06:16 2016 +0000

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/eb790c5b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
index 22136a6..9f6e9a6 100644
--- a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
@@ -27,7 +27,9 @@ private[ui] class EnvironmentPage(parent: EnvironmentTab) extends WebUIPage("")
   private val listener = parent.listener
 
   private def removePass(kv: (String, String)): (String, String) = {
-    if (kv._1.toLowerCase.contains("password")) (kv._1, "******") else kv
+    if (kv._1.toLowerCase.contains("password") || kv._1.toLowerCase.contains("secret")) {
+      (kv._1, "******")
+    } else kv
   }
 
   def render(request: HttpServletRequest): Seq[Node] = {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message