spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject spark git commit: [SPARK-16939][SQL] Fix build error by using `Tuple1` explicitly in StringFunctionsSuite
Date Sun, 07 Aug 2016 19:54:00 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-2.0 fd828e14b -> f37ed6e70


[SPARK-16939][SQL] Fix build error by using `Tuple1` explicitly in StringFunctionsSuite

## What changes were proposed in this pull request?

This PR aims to fix a build error on branch 1.6 at https://github.com/apache/spark/commit/8d8725208771a8815a60160a5a30dc6ea87a7e6a,
but I think we had better have this consistently in master branch, too. It's because there
exist other ongoing PR (https://github.com/apache/spark/pull/14525) about this.

https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console

```scala
[error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82:
value toDF is not a member of Seq[String]
[error]     val df = Seq("aaaac").toDF("s")
[error]                           ^
```

## How was this patch tested?

After passing Jenkins, run compilation test on branch 1.6.
```
build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
```

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #14526 from dongjoon-hyun/SPARK-16939.

(cherry picked from commit a16983c97b4c6539f97e5d26f163fed49872df2b)
Signed-off-by: Sean Owen <sowen@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f37ed6e7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f37ed6e7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f37ed6e7

Branch: refs/heads/branch-2.0
Commit: f37ed6e703f287907667899cd8f4a7ccee65fa91
Parents: fd828e1
Author: Dongjoon Hyun <dongjoon@apache.org>
Authored: Sun Aug 7 20:51:54 2016 +0100
Committer: Sean Owen <sowen@cloudera.com>
Committed: Sun Aug 7 20:54:05 2016 +0100

----------------------------------------------------------------------
 .../src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/f37ed6e7/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
index 73bd7e6..6edd7b0 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
@@ -93,7 +93,7 @@ class StringFunctionsSuite extends QueryTest with SharedSQLContext {
   }
 
   test("non-matching optional group") {
-    val df = Seq("aaaac").toDF("s")
+    val df = Seq(Tuple1("aaaac")).toDF("s")
     checkAnswer(
       df.select(regexp_extract($"s", "(a+)(b)?(c)", 2)),
       Row("")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message