spark-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxw...@apache.org
Subject spark git commit: [SPARK-15697][REPL] Unblock some of the useful repl commands.
Date Mon, 13 Jun 2016 18:13:19 GMT
Repository: spark
Updated Branches:
  refs/heads/branch-2.0 c01dc815d -> 413826d40


[SPARK-15697][REPL] Unblock some of the useful repl commands.

## What changes were proposed in this pull request?

Unblock some of the useful repl commands. like, "implicits", "javap", "power", "type", "kind".
As they are useful and fully functional and part of scala/scala project, I see no harm in
having them either.

Verbatim paste form JIRA description.
"implicits", "javap", "power", "type", "kind" commands in repl are blocked. However, they
work fine in all cases I have tried. It is clear we don't support them as they are part of
the scala/scala repl project. What is the harm in unblocking them, given they are useful ?
In previous versions of spark we disabled these commands because it was difficult to support
them without customization and the associated maintenance. Since the code base of scala repl
was actually ported and maintained under spark source. Now that is not the situation and one
can benefit from these commands in Spark REPL as much as in scala repl.

## How was this patch tested?
Existing tests and manual, by trying out all of the above commands.

P.S. Symantics of reset are to be discussed in a separate issue.

Author: Prashant Sharma <prashsh1@in.ibm.com>

Closes #13437 from ScrapCodes/SPARK-15697/repl-unblock-commands.

(cherry picked from commit 4134653e53adde72f53c61929473dcacae9be8b6)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/413826d4
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/413826d4
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/413826d4

Branch: refs/heads/branch-2.0
Commit: 413826d40df3f8c025101952c454a557cb8d4973
Parents: c01dc81
Author: Prashant Sharma <prashsh1@in.ibm.com>
Authored: Mon Jun 13 11:13:09 2016 -0700
Committer: Shixiong Zhu <shixiong@databricks.com>
Committed: Mon Jun 13 11:13:18 2016 -0700

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/repl/SparkILoop.scala          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/413826d4/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala
----------------------------------------------------------------------
diff --git a/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala b/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala
index bbdb992d..dcf3209 100644
--- a/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala
+++ b/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala
@@ -70,7 +70,7 @@ class SparkILoop(in0: Option[BufferedReader], out: JPrintWriter)
     echo("Type :help for more information.")
   }
 
-  private val blockedCommands = Set("implicits", "javap", "power", "type", "kind", "reset")
+  private val blockedCommands = Set[String]("reset")
 
   /** Standard commands */
   lazy val sparkStandardCommands: List[SparkILoop.this.LoopCommand] =


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


Mime
View raw message